Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(ivy): add missing dom element in render3_function tree benchmark #21476

Closed
wants to merge 1 commit into from
Closed

perf(ivy): add missing dom element in render3_function tree benchmark #21476

wants to merge 1 commit into from

Conversation

divdavem
Copy link
Contributor

This PR adds a missing wrapper element in the render3_function tree benchmark to make it more consistent with other perf tests.
This way, the DOM structure generated by this test is (as far as I can see) the same as the other ones.

(I did this change with the help of @Mlaval)

@divdavem
perf(ivy): add missing dom element in render3_function tree benchmark
997f8af 
Adds a missing <tree> wrapper element in the render3_function tree
benchmark to make it more consistent with other perf tests.
@marclaval
Copy link
Contributor

LGTM

kara
kara approved these changes Jan 11, 2018
View reviewed changes
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release comp: ivy labels Jan 11, 2018
@divdavem
Copy link
Contributor Author

@Mlaval @kara @IgorMinar Thank you for your review!

@alexeagle alexeagle closed this in 9b5a485 Jan 12, 2018
leo6104 pushed a commit to leo6104/angular that referenced this pull request Mar 25, 2018
@divdavem @leo6104
perf(ivy): add missing dom element in render3_function tree benchmark (…
2973eb0 
…angular#21476)

Adds a missing <tree> wrapper element in the render3_function tree
benchmark to make it more consistent with other perf tests.

PR Close angular#21476
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@kara kara kara approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@divdavem @marclaval @IgorMinar @kara @googlebot